refactor: make types a git submodule#255
Open
jeffrey-dot-li wants to merge 2 commits intodevelopmentfrom
Open
Conversation
justinlu1
reviewed
Aug 31, 2020
Collaborator
justinlu1
left a comment
justinlu1
left a comment
There was a problem hiding this comment.
Seems like there are some checks that failed.
Eshchock1
requested changes
Sep 1, 2020
Member
Eshchock1
left a comment
Eshchock1
left a comment
There was a problem hiding this comment.
I'm not sure if you fixed these ts errors yet
ts-jest[config] (WARN) There is a mismatch between your NodeJs version v12.18.3 and your TypeScript target esnext. This might lead to some unexpected errors when running tests with ts-jest`. To fix this, you can check https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
FAIL tests/classes.spec.ts
● Test suite failed to run
tests/classes.spec.ts:1:44 - error TS2307: Cannot find module '~/types' or its corresponding type declarations.
1 import {Notes, Subjects, Suggestions} from '~/types'
~~~~~~~~~
tests/classes.spec.ts:2:22 - error TS2307: Cannot find module '~/types/notes' or its corresponding type declarations.
2 import { Note } from '~/types/notes';`
But fix your merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the types folder a submodule that can be reused at https://github.com/Quento-Solutions/Quento-Types